Entry read support local node rack awareness#4062
Open
hangc0276 wants to merge 3 commits intoapache:masterfrom
Open
Entry read support local node rack awareness#4062hangc0276 wants to merge 3 commits intoapache:masterfrom
hangc0276 wants to merge 3 commits intoapache:masterfrom
Conversation
hangc0276
requested review from
StevenLuMT,
dlg99,
eolivelli,
merlimat,
wenbingshen and
zymap
horizonzy
reviewed
Aug 30, 2023
| if (null == node || null == node.getAddr()) { | ||
| return UNKNOWN_RACK; | ||
| } | ||
| return node.getNetworkLocation(); |
Member
There was a problem hiding this comment.
If the network location is /default-rack, shall we think of it as UNKNOWN_RACK?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In order to match the local node region/rack awareness both on entry write and read, we need to support the following feature
Modification
The PR aims to support entry read local node awareness placement policy.